[Poppler-bugs] [Bug 50992] library should be thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50992

--- Comment #65 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
(In reply to comment #64)
> (In reply to comment #63)
> > [...] And as a last
> > statement: My work on this thread begin to exceed the time where I do it
> > only experimentally. I'll continue only if the community wants to have a
> > solution for it.
> 

Sorry, I was probably misunderstandable: What I meant was that it is hard to
keep these changes appliable to git master. It would be much easier to have it
committed and then make these smaller changes later...

> I am not sure what "this thread" refers to: If you mean the "getDocInfo"
> stuff, then I would just add that it seems to be part of the internal
> Poppler API which has no stability guarantees at all. Hence you could remove
> the old call and if someone used it, that is his own fault. (At least this
> is how I understood the mailing list discussions concerning such topics.)

Regarding getDocInfo: I think I made it TOO complicate. It can probably removed
in PDFDoc.cc / *.h and we can call 

    XRef *xref = m_doc->doc->getXRef()->copy();
    Object *infoObj = xref->getDocInfo(&info);

in poppler-document.cc at the appropriate places. This is thread safe, too.

> 
> If you refer to the whole threading work, as maintainer of qpdfview and
> hence Poppler user, I am very much interested in seeing this resolved. I was
> just testing your patch again yesterday and the perceived difference is
> rather noticeable. Especially when searching the document as the rendering
> does not stall the search any more. (Btw., I always have to apply with
> "--ignore-space-changes".)
> 
> Your work on this is very much appreciated. Thanks!

Don't thanks for nothing :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20120930/b21654db/attachment.html>