[Poppler-bugs] [Bug 55977] handling of rtl text inversion is too naive

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55977

--- Comment #30 from Albert Astals Cid <tsdgeos at terra.es> ---
(In reply to comment #29)
> Created attachment 73767 [details] [review]
> allow dumping and finding of rtl text in logical order, using icu only
> 
> 
> hey albert,
> 
> this patch does the same as my previous, but with icu only. fribidi has been
> removed.

You are removing lots of code, e.g. the "// Note: This code treats numeric
characters (European and", why? Can't we use that when ICU is not there?

> cmake related stuff is there, but i have no idea on how to use it. my env is
> debian linux with gnome.

And what's the problem? cmake works perfectly in debian linux with gnome :-)

> as for finding (a) better place(s) to store reordering_mode, i'd like to
> consult you.

Sure, what's the question?

> 
> thanks for considering my patch,
> alex

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130210/21f2a50d/attachment.html>