[Poppler-bugs] [Bug 37347] A pdf with a grid of thin lines is almost unreadable and looks awful

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37347

--- Comment #44 from Albert Astals Cid <tsdgeos at terra.es> ---
(In reply to comment #43)
> (In reply to comment #42)
> > I think it'd be cleaner reusing the RenderHint enum instead of adding a
> > setter that takes an int. 
> 
> I thought about that first, but hint is a bit mask with a boolean meaning
> (switch it on / off), but here we have a three state logic. Or would You
> prefer to omit the shape mode and then switch on the "enhance thin lines" in
> solid mode?

Well, the thing is that "thin lines enhacement" clearly fit into the
"RenderHint" idea so I'd like to use that. We have two options one as you say
only provide an enum for on/off, but you added 3 states so i guess it makes
sense to export the 3. The option to export the three is add two enums, say
ThinLineSolid and ThinLineShape and document that if both are present one
"wins" over the other.

I think this second solution might work, what do you think?

> 
> > Also a better explanation than
> > splashThinLineDefault would be needed, i don't expect "users" of the Qt
> > frontend to necessarily understand what splashThinLineDefault means
> 
> You think something about "No special handling for thin lines"? Or if we
> omit the "shape mode" we could just comment "enhance thin line on/off"!

To be honest i didn't really understand the difference between the 3 modes so
i'm not really sure i can comment in what should be written, but
splashThinLineDefault is what should not :D Nobody will understand that without
having to read the code (and a lot of code)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130219/e9cb91f0/attachment.html>