[Poppler-bugs] [Bug 59927] make qt4 frontend thread-safe

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59927

Thomas Freitag <Thomas.Freitag at alfa.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73724|0                           |1
        is obsolete|                            |

--- Comment #12 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
Created attachment 73820
  --> https://bugs.freedesktop.org/attachment.cgi?id=73820&action=edit
fix font info stuff, share annot over threads

(In reply to comment #5)
> Personally i don't think the define makes sense, just depend on the poppler
> version and that's it.

Ok, I removed it from this patch

> There's on true that shold be gTrue to be pedantically correct

Ok, I changed it. But to be pedantically, too, I only correct MY changes, NOT
the other uses of true/false :-)

> Why the setoverprint code move? (I think setoverprint should be also gone
> from globalparams and move to the outputdev itself, this way we can have one
> with overprint and one without overprint with no fear that it'll collide one
> with eachother, but that's for the future :D)

Future is there, done.

!!!!!!!!!!!!WARNING!!!!!!!!!!!!
Running Adam's test, I encounterd that there is an "unlock" missing in XRef.cc.
This can cause deadlocks with the actual git master, so this part of the patch
should be committed asap to avoid bug reports. It will be solved in better way
in bug 59933, but I stopped working on it because I think we should close this
bug first!

Another comment to this patch: I insert some locks/unlocks in the Annot stuff,
because Adam's test case shares annotations over threads and can modify an
annotation at the same time in differnt threads. I don't think that this is a
normal use case, but nevertheless, better to have it!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130129/7f113627/attachment.html>