[Poppler-bugs] [Bug 67278] Does not build with gtk+ master (3.10) when deprecated symbols are disabled

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67278

--- Comment #3 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #2)
> (In reply to comment #1)
> > why does it fail to build? it should give just compile warnings, that we
> > should silence, but I don't think we need to change the code for symbols
> > deprecated in a gtk+ version higher than the required one
> 
> At least in GNOME, jhbuild disables deprecated symbols by default.
> 
> I saw 2 options:
> 1. Add an option in jhbuild to not check deprecated symbols.
> 2. Migrate the old API to the new one.
> 
> In the long term, (2) is better IMVHO.
> 
> The changes I applied are the ones suggested in the migration guide from
> gtk+2 to Gtk+3:
> https://developer.gnome.org/gtk3/stable/checklist-named-icons.html
> 
> They did not bite before, but it is supposed to be part of the migration.

We depend on 3.0 and fortunately stock icons are present in 3.0. It's very
unfortunate that stock icons are deprecated in 3.10, but I don't think we
should migrate our code for an unstable gtk version that hasn't even been
released yet. I will keep using stock icons while they are available because
they fail at compile time, not like the string you used, where a typo will not
be caught by the compiler. Given the amount of gtk symbols that are being
deprecated lately I don't think jhbuild should disable deprecated api by
default, and I recommend you to change that configuration in your .jhbuildrc if
possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130725/e15406c4/attachment.html>