[Poppler-bugs] [Bug 64821] [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=64821

--- Comment #24 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 86682
  --> https://bugs.freedesktop.org/attachment.cgi?id=86682
[PATCH v8 09/15] glib: Private function
_poppler_link_mapping_new_from_annot_link()

Review of attachment 86682:
-----------------------------------------------------------------

::: glib/poppler-page.cc
@@ +1158,5 @@
> +  PopplerLinkMapping *mapping;
> +  double width, height;
> +
> +  g_return_val_if_fail (POPPLER_IS_DOCUMENT (document), NULL);
> +  g_return_val_if_fail (link != NULL, NULL);

Do not use g_return macros in private methods, This is called only internally.

@@ +1160,5 @@
> +
> +  g_return_val_if_fail (POPPLER_IS_DOCUMENT (document), NULL);
> +  g_return_val_if_fail (link != NULL, NULL);
> +
> +  g_assert (page_num >= 0);

This is impossible to fail, it's called from a PopplerPage passing its index.

@@ +1161,5 @@
> +  g_return_val_if_fail (POPPLER_IS_DOCUMENT (document), NULL);
> +  g_return_val_if_fail (link != NULL, NULL);
> +
> +  g_assert (page_num >= 0);
> +  g_assert (page_num < poppler_document_get_n_pages (document));

Ditto.

@@ +1242,4 @@
>        /* Create the mapping */
> +      PopplerLinkMapping *mapping = _poppler_link_mapping_new_from_annot_link (page->document,
> +									       page->index,
> +									       links->getLink (i));

Better split this in two lines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131105/78c4302c/attachment.html>