[Poppler-bugs] [Bug 70983] Add implementation of Square and Circle annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70983

--- Comment #7 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #6)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > @@ +433,5 @@
> > > > +  border = new AnnotBorderArray ();
> > > > +  border->setWidth (1.5);
> > > > +
> > > > +  annot = new AnnotGeometry (doc->doc, &pdf_rect, Annot::typeCircle);
> > > > +  annot->setBorder (border);
> > > 
> > > Why do we set a border by default? The BS entry is optional.
> > 
> > If we don't set the border, we get an "invisible" square/circle.
> 
> This is a bug in poppler core then. Actually, it seems we are not exactly
> following the spec for borders, I'll fix it.

I've just sent a few patches to the list that should fix this problem. With
those patches we don't need to set any border width at all to have square and
circle annotations, so for now I would not expose set_border_width, because
it's not needed and we might expose borders differently (using a
PopplerAnnotBorder object or something like that).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131126/f2231bbc/attachment.html>