[Poppler-bugs] [Bug 69978] Make demo extensible for other type of annotations

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 4 09:04:33 PDT 2013


https://bugs.freedesktop.org/show_bug.cgi?id=69978

--- Comment #17 from Germán Poo-Caamaño <gpoo at gnome.org> ---
(In reply to comment #13)
> Comment on attachment 86867 [details] [review]
> glib: Prepare UI to add multiple annotations type in demo
> 
> Review of attachment 86867 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: glib/demo/annots.c
> @@ +38,5 @@
> >  
> > +enum {
> > +    ANNOTS_NONE,
> > +    ANNOTS_TEXT
> > +};
> 
> Why not using PopplerAnnotType?

I missed this one comment.

Because:
- I needed a way to avoid any interaction in the drawing area
- To use the same value returned by the combobox for selecting a
  new annotation without the hassle of converting the enum to
  strings and viceversa (when using gtk_combo_box_text_append)

I can change it or use gtkcombobox and a model.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131004/a236296a/attachment.html>


More information about the Poppler-bugs mailing list