[Poppler-bugs] [Bug 51487] [PATCH] Add support for TextMarkup Annotations in glib frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51487

--- Comment #24 from Germán Poo-Caamaño <gpoo at gnome.org> ---
Created attachment 88275
  --> https://bugs.freedesktop.org/attachment.cgi?id=88275&action=edit
Screenghost that shows the difference between cairo and a list of rectangles

The demo add two implementations to set the Quadrilaterals.  Using
cairo_region_t or getting a GList of rectangles.

For the GList of rectangles I use a deprecated function of poppler-glib: 
poppler_page_get_selection_region() that deprecated in favor of
poppler_page_get_selected_region().

In the screenshot it is possible to see the difference of both implementations:
* With the GList we get one rectangle per line and it is rendered
  with small rectangles with small rounding ends.
* With cairo_region_t we get only 2 rectangles, making one huge rounding ends
  and one smaller.

The issue with cairo_region_t is exacerbated when using underline, squiggly
or strikeout.  Because those are rendered per rectangle. So, instead of
having every line underline or strikeout, there one big underline for the
big rectangle.

Anyhow, you can try the patch setting cairo = TRUE|FALSE inside
pgd_annots_update_selected_text().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131029/df42f56f/attachment.html>