[Poppler-bugs] [Bug 81665] Extend support for free text annotations.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=81665

--- Comment #11 from Jose Aliste <jose.aliste at gmail.com> ---
Comment on attachment 103426
  --> https://bugs.freedesktop.org/attachment.cgi?id=103426
[PATCH 1/4] glib: Extend FreeText annotation support

Review of attachment 103426:
-----------------------------------------------------------------

This looks much better. Although, see the comment bellow

::: glib/poppler-annot.cc
@@ +1896,5 @@
> +  annot = static_cast<AnnotFreeText *>(POPPLER_ANNOT (poppler_annot)->annot);
> +  annot->setAppearanceString (da);
> +  delete da;
> +}
> +

We already know that we want the font type to be changed accessed, so the API
should have some PangoFontDescription or so to get and set the font + the
color. Even if Poppler Core does not support different fonts in FreeText Annot,
I believe we want the API to be right in glib right away.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140725/a10848db/attachment.html>