[Poppler-bugs] [Bug 80250] Fix moc-qt5 detection

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80250

--- Comment #9 from Hib Eris <hib at hiberis.nl> ---
(In reply to comment #8)
> > Matching with 'moc 5' is wrong
> No, it's not wrong,

All evidence suggests it has never worked for anyone. Also, looking at the code
it seems to be a copy & paste error. So it seems wrong to me. 

> if it returned moc 5 in the future (you can't predict
> past or future behavior) i don't see any problem on moc-qt5 returning moc 5.9

But it doesn't return moc 5 now nor did it ever. I can think of lots of other
strings it might return in the future, but as we cannot predict the future it
seems silly to have checks making guesses about that.

> So please, just add it to the regexp.

I do not agee with this, but when you really want to go that way, I will send a
new patch for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140619/80f9792e/attachment.html>