[Poppler-bugs] [Bug 78831] [Patch] Faster AES decryption

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78831

--- Comment #5 from Jan Ziak <0xe2.0x9a.0x9b at gmail.com> ---
(In reply to comment #4)
> Hi, I'm not sure that initializing the arrays through that MulTableInit
> class is a good idea.
> 
> Relying on a global/static variable ctor is usually discouraged, because
> it's hard to predict the order those variables are initialized. In order
> words, what happens if you open an encrypted document from another
> global/static variable's ctor? Has the decryption table been initialized
> already or not?

I see. I suggest we introduce a boolean variable that we would check before
every AES decryption. Would this be OK with you? Does the variable need to be
thread-safe?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140521/68e1bc13/attachment.html>