[Poppler-bugs] [Bug 36653] Missing functions for setting document's properties

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Oct 5 11:34:35 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=36653

--- Comment #9 from Scott West <scott.gregory.west at gmail.com> ---
(In reply to Albert Astals Cid from comment #8)
> Please use proper style for the core code, i.e. don't add those jumps on
> function declarations.
> 
> Also no need to check if the xref is there or not, if the doc doesn't have
> an xref you don't really have a doc and should be calling this anyway.

Thanks for the comments! I've removed the check on the Doc's XRef and modified
the type signature appropriately.

What "jumps" on the declarations? Do you mean the newline between the get and
set in PDFDoc.h? Is there a style guide somewhere for future reference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20141005/d9492149/attachment.html>


More information about the Poppler-bugs mailing list