[Poppler-bugs] [Bug 79936] Add support for printing to a Windows printer from pdftocairo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79936

--- Comment #8 from Adrian Johnson <ajohnson at redneon.com> ---
I finally found some time to look at this bug again. I will attach some patches
that fix a number of issues. Have a look and check that I have not broken
anything.

The major fix is the for the page size issue. I have fixed it to make all the
various options (-paper, -origpapersizes, -noshrink, -nocenter) work. I had the
same issue you mentioned with images not appearing. I have fixed it in cairo.
The patch is:

http://cgit.freedesktop.org/cairo/commit/?id=0aa43ed886c0f8468a21a470f2f024bd4d8a4513

I didn't like #including pdftocairo-win32.cc so I changed it to be a standalone
.cc file. I also added the ability to print to a file by specifying an output
file on the command line.

The only remaining issue I have is with the numeric value for the source
option. If we are going to support non standard sources we should use
DeviceCapabilities() with DC_BINNAMES to obtain the names and allow the user to
enter the text name of the source. Otherwise I suggest removing the numeric
value capability.

I also noticed in the documentation for DocumentProperties() at
http://msdn.microsoft.com/en-us/library/windows/desktop/dd183576%28v=vs.85%29.aspx

that we are not doing step 5 in the "To make changes to print settings that are
local to an application, an application should follow these steps:" section. It
seems to work without the extra call to DocumentProperties() but I am wondering
if we should do exactly what the documentation says to do to change the print
settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140914/801d3749/attachment.html>