[Poppler-bugs] [Bug 79936] Add support for printing to a Windows printer from pdftocairo

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Sep 27 01:41:04 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=79936

--- Comment #36 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 106269
  --> https://bugs.freedesktop.org/attachment.cgi?id=106269
fix page size selection

Review of attachment 106269:
-----------------------------------------------------------------

::: utils/pdftocairo-win32.cc
@@ +227,5 @@
> +    *h = GetDeviceCaps (hdc, PHYSICALHEIGHT)*72.0/y_dpi;
> +  } else {
> +    *w = GetDeviceCaps (hdc, HORZRES)*72.0/x_dpi;
> +    *h = GetDeviceCaps (hdc, VERTRES)*72.0/y_dpi;
> +  }

Could we move all this to a separate function that returns the width/height to
be called before beginPage only for win32? That way we don't need to change
beginPage in pdftocairo.cc

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140927/b330cf86/attachment.html>


More information about the Poppler-bugs mailing list