[Poppler-bugs] [Bug 16770] support for digital signatures

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=16770

--- Comment #47 from Albert Astals Cid <aacid at kde.org> ---
Nice work.

Some small things that need fixing.

the cmake way of using pkgconfig is very simple, see
./cmake/modules/FindGTK.cmake for example

You need to free more Objects, every time you do a get object an object you
have to free it, e.g. in countSignatures you need to free fields, f, type, obj1

The indentation is a bit broken, i know poppler indentation (2 soft spaces, 8
hard tabs) is a craaaaazy, but at least it'd be cool if your own functions were
consistent, in validateSignature you mix tabs and spaces.

Also running valgrind it shows some memory leaks, one example

==27912==    by 0x657248F: CERT_NewTempCertificate (in
/usr/lib/x86_64-linux-gnu/libnss3.so)
==27912==    by 0x4F9C4A1:
SignatureHandler::CMS_SignedDataCreate(NSSCMSMessageStr*)
(SignatureHandler.cc:172)
==27912==    by 0x4F9C561: SignatureHandler::SignatureHandler(unsigned char*,
int) (SignatureHandler.cc:122)
==27912==    by 0x4F9383F: PDFDoc::validateSignature(int, bool) (PDFDoc.cc:534)


The file in https://bugs.kde.org/attachment.cgi?id=91442 aborts

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150824/847211ad/attachment.html>