[Poppler-bugs] [Bug 90795] [patch] Allow configuring SPLASH_CMYK support with --enable-cmyk as in xpdf

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90795

--- Comment #4 from William Bader <williambader at hotmail.com> ---
Created attachment 116937
  --> https://bugs.freedesktop.org/attachment.cgi?id=116937&action=edit
file that needs poppler with SPLASH_CMYK for pdftops -level1sep to work

I left SPLASH_CMYK disabled by default because it has always been disabled by
default.

I think that it should always be enabled, and it shouldn't be an option to
enable or disable.

pdftops needs SPLASH_CMYK to work correctly, and building poppler with
SPLASH_CMYK has almost no performance penalty.

The best argument for leaving it an option is that Derek Noonburg made it an
option in xpdf, and he knew what he was doing, so maybe he had a good reason to
disable it.

For more details:
"pdftops -level1sep" requires SPLASH_CMYK to generate correct output for files
that it needs to rasterize.  I have attached an example file.

SPLASH_CMYK mainly enables "case" entries and "if" statements for
splashModeCMYK8 and splashModeDeviceN8 in Splash.cc and SplashOutputDev.cc
except for a few places like SplashOutputDev::univariateShadedFill() where it
adds the line
 
pattern->getShading()->getColorSpace()->createMapping(bitmap->getSeparationList(),
SPOT_NCOMPS);

I suspect that the main cost of enabling SPLASH_CMYK is a small increase in
code size and rather than any change in performance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150704/f6704da9/attachment.html>