[Poppler-bugs] [Bug 89502] New: Compilation failure with clang - minor cleanup patch to ProfileData and Gfx

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89502

            Bug ID: 89502
           Summary: Compilation failure with clang - minor cleanup patch
                    to ProfileData and Gfx
           Product: poppler
           Version: unspecified
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: cpp frontend
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: schwehr at google.com

Created attachment 114163
  --> https://bugs.freedesktop.org/attachment.cgi?id=114163&action=edit
Patch to poppler 0.32.0 for ProfileData.{cc,h} and Gfx.cc

I got a link error for multiply defined ProfileData classes.  The attached
patch moves the default constructor for ProfileData from the implementation .cc
to the header to fix the linking issue.  The compiler was creating a default
constructor when seeing the header and that constructor then clashed with the
one created by ProfileData.cc.  The patch also switches the initialization of
data members to an initializer list.

While debugging this, I looked at Gfx.cc and did some minor cleanup on the use
of ProfileData.

I'm using a non-standard build system and GCC 4.9.x with various patches, but
this patch should be safe for any platform.

Patch is against 0.32.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20150309/74cd37fc/attachment.html>