[Poppler-bugs] [Bug 94378] Implement digital signature support (qt frontends)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94378

--- Comment #12 from Albert Astals Cid <aacid at kde.org> ---
(In reply to Hanno Meyer-Thurow from comment #11)
> (In reply to Albert Astals Cid from comment #10)
> > +    private:
> > +	SignatureStatus signature_status;
> > +	CertificateStatus certificate_status;
> > +
> > +	QString signer_name;
> > +	time_t signing_time;
> > 
> > This is still bad, you need to have just a d-pointer as private member in
> > there and then that pointer containing the rest of members.
> 
> Whatever a d-pointer is. 
google for it, it's a quite common name/construct, that's why i asked if you
knew what it was a few comments ago.

> To simplify, SignatureValidationInfo class may just
> receive the pointer to core SignatureInfo instance. Query and return the
> info from core SignatureInfo.
> 
> Would that be okay?

You can store the  SignatureInfo in the d-pointer if you want, we still want a
d-pointer to make it easier to maintain binary compatibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20161205/3951409c/attachment.html>