[Poppler-bugs] [Bug 81760] pdftops sometimes creates huge PS 3 files out of small PDFs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=81760

--- Comment #25 from William Bader <williambader at hotmail.com> ---
Thanks for looking at the patches.

>The LZW and Flate compression should be in two separate commits in order to preserve the provenance

OK. I'll try to have that ready next week. One of my first patches was just
LZW, but I made a few improvements (like initializing more variables) in the
second patch with LZW+Flate.

>I don't think we want to add these to gitignore.

OK. I did that so my test files wouldn't get picked up in my diffs.

>Why use enums to define constants? The rest of the code uses #define or static const.

enums for constants are better style, since they are scoped while #defines are
global.

Let me know if you still want me to convert the enums to #defines.

>What are the Gfx.cc changes for?

They are a fix from xpdf. Should I pull them out into a separate patch?

>I now see some of these are to wrap the FlateEncoder class

Yes, I had to wrap all references to the FlateEncoder class.

I left the useFlate and useLZW declarations unwrapped so that I didn't have to
wrap every use, but I had to wrap all references to the class.

I can remove the #if in the place that you mentioned. I thought that it was
better to wrap it to avoid generating extra code and data.

William

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160216/5fda061b/attachment.html>