[Poppler-bugs] [Bug 94201] refactor GooString

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 10 08:07:57 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=94201

--- Comment #8 from Jakub Kucharski <jakubkucharski97 at gmail.com> ---
(In reply to Albert Astals Cid from comment #7)
> But the only case when s will be null, length will be 0, so memcpy will do
> nothing since we're asking to copy no bytes at all, also why the memcpy ->
> memmove change?
> 
> From what i can see s and s1 can never overlap, you say the grealloc says
> otherwise, but i tend to disagree, could you actually change 
> 
> qt4/tests/check_qt4_goostring.cpp
> 
> so that it has one of those cases where s and s1 overlap?

Ok, my bad. I'll leave GooString::resize() as it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160510/ebdf5755/attachment.html>


More information about the Poppler-bugs mailing list