[Poppler-bugs] [Bug 97506] GooString wastes 4 bytes on 64-bit systems

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97506

--- Comment #8 from Jakub Kucharski <jakubkucharski97 at gmail.com> ---
(In reply to Albert Astals Cid from comment #7)
> Well, it's following your math, no?
> 
> static const int STR_STATIC_SIZE = STR_FINAL_SIZE - sizeof(int) -
> sizeof(char*);
> so 
> STR_STATIC_SIZE = 32 - 4 + 8 = 36
> so if STR_STATIC_SIZE is already 36 the whole thing will be bigger than 32,
> no?

No. There is no addition. STR_STATIC_SIZE = 32 - 4 - 8 = 20.

My only worry here is performance (due to memory alignment). Benchmarks could
help, but recently I don't have time for figuring out how to properly benchmark
it (or for anything else for that matter). So I suggest letting it hang here
until someone, who has time for that, benchmarks it.

Cheers,
Jakub

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20160905/2ade8546/attachment-0001.html>