[Poppler-bugs] [Bug 101811] [PATCH] remove unused variables

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Aug 1 16:57:13 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=101811

--- Comment #3 from Albert Astals Cid <aacid at kde.org> ---
(In reply to Jannick from comment #2)
> The clean-up is meant to pacify the compiler complaining about unused or
> even uninitialized variables in the code given the configuration.
> 
> Just to understand what you are saying and to be productive: Where exactly
> breaks your code, since mine works well under my configuration?

You removed the calls to read16 so the stream is not advanced and thus any
subsequent read is wrong. 

> 
> Probably a good idea to make the *compiler* throw either an information or
> an error that the internal DCTStream is unmaintained and have the dev use
> the alternative code.

Which version are you using? You have to explicitly say you want the
unmaintained code on configure / cmake time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170801/0576c7c3/attachment-0001.html>


More information about the Poppler-bugs mailing list