[Poppler-bugs] [Bug 102290] [PATCH] Replace Splash font rendering by Qt font rendering

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Aug 21 12:55:46 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=102290

--- Comment #2 from oliver.sander at tu-dresden.de ---
> if (!(render & 1))
> seems highly suspicious

I took this from the Splash-based font rendering code, which has the same text.
 I guess the code does only 'fill' text rendering for now, but that is not a
regression.  At least a few others of the mode seem reasonably straightforward,
but I don't have any documents to test that with.

> And how is this thing loading fonts?

The updateFont method does (e.g.)

  const char* fontData = font->readEmbFontFile(xref, &fontDataLen);
  m_rawFont = std::unique_ptr<QRawFont>(new QRawFont(QByteArray(fontData,
fontDataLen), fontSize));

Isn't that good enough?  Am I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170821/25f8675f/attachment.html>


More information about the Poppler-bugs mailing list