[Poppler-bugs] [Bug 99883] New: pdfimages extracts lots of same images with the same object number.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99883

            Bug ID: 99883
           Summary: pdfimages extracts lots of same images with the same
                    object number.
           Product: poppler
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: utils
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: ryanorz at 126.com

Created attachment 129787
  --> https://bugs.freedesktop.org/attachment.cgi?id=129787&action=edit
problem file

I have a pdf file, pdfimages list a lot of images with the object number. These
images are the same. There are only about a thousand pictures with diffrent
object number, but pdfimages list more than 256,000 items. Finally, pdfimages
extract all pictures listed and most of them are the same. The total size of
all pictures is really huge. I upload the pdf, and my simple patch below ( may
not good, but work :D ).

>From 237f4e0887eff2f22d5542dfed33fa94a8c7b0ff Mon Sep 17 00:00:00 2001
From: Ryan <ryanorz at 126.com>
Date: Tue, 21 Feb 2017 16:11:53 +0800
Subject: [PATCH] Fix(poppler-utils): pdfimages extract too many same pictures
 with the same object number.

---
 utils/ImageOutputDev.cc | 8 ++++++++
 utils/ImageOutputDev.h  | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/utils/ImageOutputDev.cc b/utils/ImageOutputDev.cc
index 5de51ad..26bf95b 100644
--- a/utils/ImageOutputDev.cc
+++ b/utils/ImageOutputDev.cc
@@ -442,6 +442,14 @@ void ImageOutputDev::writeImageFile(ImgWriter *writer,
ImageFormat format, const
 void ImageOutputDev::writeImage(GfxState *state, Object *ref, Stream *str,
                                int width, int height,
                                GfxImageColorMap *colorMap, GBool inlineImg) {
+  if (ref->isRef()) {
+    const Ref imageRef = ref->getRef();
+    if (refNums.find(imageRef.num) != refNums.end())
+      return;
+    else
+      refNums.insert(imageRef.num);
+  }
+
   ImageFormat format;

   if (dumpJPEG && str->getKind() == strDCT &&
diff --git a/utils/ImageOutputDev.h b/utils/ImageOutputDev.h
index a694bbc..89c67ac 100644
--- a/utils/ImageOutputDev.h
+++ b/utils/ImageOutputDev.h
@@ -35,6 +35,7 @@
 #endif

 #include <stdio.h>
+#include <set>
 #include "goo/gtypes.h"
 #include "goo/ImgWriter.h"
 #include "OutputDev.h"
@@ -173,6 +174,7 @@ private:
   int pageNum;                 // current page number
   int imgNum;                  // current image number
   GBool ok;                    // set up ok?
+  std::set<int> refNums;
 };

 #endif
-- 
2.10.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170221/03934df8/attachment.html>