[Poppler-bugs] [Bug 99357] Fix segfault/assert if LinkDestination is constructed with invalid input string

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99357

--- Comment #4 from Christoph Cullmann <cullmann at kde.org> ---
I do that e.g. to handle table of contents, just like okular does it in
generator_pdf.cpp, too:

     if (!e.attribute(QStringLiteral("Destination")).isNull())
        {
            Okular::DocumentViewport vp;
            fillViewportFromLinkDestination( vp,
Poppler::LinkDestination(e.attribute(QStringLiteral("Destination"))) );
            item.setAttribute( QStringLiteral("Viewport"), vp.toString() );
        }

=> if you have any broken entry there, that will segfault, which IMHO is not
nice.

Now you can argue that the toc QDomDocument should contain only wellformed
things, still I see no real point in not avoiding the doom in the constructor
as that check is really cheap.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170112/1e4d4cf6/attachment.html>