[Poppler-bugs] [Bug 101776] [PATCH] add author member to annotation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101776

--- Comment #1 from oliver.sander at tu-dresden.de ---
Comment on attachment 132658
  --> https://bugs.freedesktop.org/attachment.cgi?id=132658
patch adding author member to annotation

Review of attachment 132658:
-----------------------------------------------------------------

::: Annot.cc
@@ -581,4 @@
>  
>    // Sets the annot contents to new_content
>    // new_content should never be NULL
> -  virtual void setContents(GooString *new_content);

You are apparently doing whitespace changes to this line.  Please don't do
that.

@@ -602,4 @@
>    AnnotSubtype getType() const { return type; }
>    PDFRectangle *getRect() const { return rect; }
>    void getRect(double *x1, double *y1, double *x2, double *y2) const;
> -  GooString *getContents() const { return contents; }

Whitespace changes again

@@ -660,4 @@
>    PDFRectangle *rect;               // Rect
>  
>    // optional data
> -  GooString *contents;              // Contents

Whitespace?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170714/97a46032/attachment-0001.html>