[Poppler-bugs] [Bug 101818] New: [PATCH] ./configure --disable-fixedpoint actually enables fixedpoint support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=101818

            Bug ID: 101818
           Summary: [PATCH] ./configure --disable-fixedpoint actually
                    enables fixedpoint support
           Product: poppler
           Version: unspecified
          Hardware: ARM
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: r.hieber at pengutronix.de

Created attachment 132731
  --> https://bugs.freedesktop.org/attachment.cgi?id=132731&action=edit
configure.ac: fix --disable-FEATURE actually enabling the feature

I'm currently packaging poppler for PTXdist, and I noticed that configure.ac
suffers from a frequently seen antipattern, which is to use

  AC_ARG_ENABLE(feature, help, action-if-given, action-if-not-given)

as

  AC_ARG_ENABLE(feature, help, action-if-enabled, action-if-disabled).

However, action-if-given is also evaluated for --disable-FEATURE (with
enableval=no), which results in --disable-FEATURE and --enable-FEATURE doing
the same in this case.

This patch rewrites this behaviour for the --disable-single-precision,
--disable-fixedpoint and --disable-cmyk arguments accordingly, so users are not
confused if they want to be explicit about disabling those options.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170717/97b45d07/attachment.html>