[Poppler-bugs] [Bug 99271] make it possible to extract digital signature data (also in pdfsig)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99271

--- Comment #20 from Albert Astals Cid <aacid at kde.org> ---
Some comments:
 * Please provide a commit log
 * The code is full of memory leaks, every time you "use" an Object, you need
to free() it, yes the API is awful, maybe you just want to wait until i merge
my better_object branch so that you don't have to worry about it
 * Please move the getHashAlgorithmName function to pdfsig, it is something
that i guess some people would like to translate (CJK?, Arabic?) and we don't
provide any translations support on the poppler core, so better not to have
things that people may want to show on a UI on poppler core either
 * Don't break the ABI on the Qt side of things, just introduce another
function
 * The extra code in FormFieldSignature::validate seems like it really should
be in the core since other bindings will want to do the same?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20170619/a3a61250/attachment.html>