[Poppler-bugs] [Bug 103590] New: CMake: ENABLE_GLIB vs. WITH_GLIB

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Nov 6 10:58:23 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103590

            Bug ID: 103590
           Summary: CMake: ENABLE_GLIB vs. WITH_GLIB
           Product: poppler
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
          Assignee: poppler-bugs at lists.freedesktop.org
          Reporter: r.hieber at pengutronix.de

Created attachment 135254
  --> https://bugs.freedesktop.org/attachment.cgi?id=135254&action=edit
CMake: remove ENABLE_GLIB in favour of WITH_GLIB from
macro_optional_find_package(GLIB)

When configuring poppler 0.60.1 with ccmake, I can see both ENABLE_GLIB and
(further down) WITH_GLIB. As I understand the code, both of them need to be set
for GLIB to be used. Since WITH_GLIB is the guard used in
`macro_optional_find_package(GLIB)`, I think that `ENABLE_GLIB` can be spared.
See the attached patch, which works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171106/014c6b1d/attachment.html>


More information about the Poppler-bugs mailing list