[Poppler-bugs] [Bug 103621] MSVC does not find strtok_r

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Nov 11 23:13:29 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103621

--- Comment #5 from Albert Astals Cid <aacid at kde.org> ---
(In reply to mr NAE from comment #2)
> Functions in the goo\glibc.h are defined as C-function, so somewhere should
> be a C-file with these functions, but the Poppler's source contains a C++
> compiled files where you declare the C-functions. That is why I used 
> __cplusplus guards in header - for further rename of the C++ compiled files
> with C-function declarations to .c files
> 
> Other reason to use __cplusplus guards is codestyle - same sense as for
> static_cast (sometimes) - ugly code for ugly design. This codestyle should
> help to understand how to make the design better or warn user/coder about
> something unusual.
> 
> Best regards,
>  Aleksey Nikolaev

You really lost me there, are you saying "this is unneeded but i just added
them because i think it makes sense style wise"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171111/26c449fb/attachment.html>


More information about the Poppler-bugs mailing list