[Poppler-bugs] [Bug 99416] Sign PDF with digital signature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=99416

--- Comment #55 from Theofilos Intzoglou <int.teo at gmail.com> ---
Comment on attachment 134080
  --> https://bugs.freedesktop.org/attachment.cgi?id=134080
pdfsig: add -nssdi option v2

Review of attachment 134080:
-----------------------------------------------------------------

Omiting the nssdir option doesn't result in nssDir.getCString() being equal to
nullptr so the following changes are required.

::: utils/pdfsig.cc
@@ +197,4 @@
>        fws->setSignatureType(ETSI_CAdES_detached);
>      const char* pw = (strlen(password) == 0) ? nullptr : password;
>      const char* rs = (strlen(reason) == 0) ? nullptr : reason;
> +    if (fws->signDocument(nssDir.getCString(), certNickname, digestName, pw, rs)) {

nssDir.getCString() should be :
nssDir.getLength() ? nssDir.getCString() : nullptr

@@ +217,4 @@
>    }
>  
>    for (unsigned int i = 0; i < sigCount; i++) {
> +    sig_info = sig_widgets.at(i)->validateSignature(nssDir.getCString(), !dontVerifyCert, false, -1 /* now */);

nssDir.getCString() should be :
nssDir.getLength() ? nssDir.getCString() : nullptr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171126/39d820ed/attachment.html>