[Poppler-bugs] [Bug 103117] New: [PATCH] Cleanup in ArthurOutputDev::updateFont
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu Oct 5 21:44:35 UTC 2017
https://bugs.freedesktop.org/show_bug.cgi?id=103117
Bug ID: 103117
Summary: [PATCH] Cleanup in ArthurOutputDev::updateFont
Product: poppler
Version: unspecified
Hardware: Other
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: arthur backend
Assignee: poppler-bugs at lists.freedesktop.org
Reporter: oliver.sander at tu-dresden.de
Created attachment 134693
--> https://bugs.freedesktop.org/attachment.cgi?id=134693&action=edit
The patch
The attached patch contains a bit of cleanup in the updateFont method of the
ArthurOutputDev class, in the wake of cc43c720e857548175a9e35b0686a1a7a8957f50
.
In particular, it does
- remove some goto-style error handling
- use nullptr
- use std::unique_ptr (fixes a leak)
- remove unused data member m_currentFont
- remove some unused forward declarations
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171005/bc03b0ec/attachment.html>
More information about the Poppler-bugs
mailing list