[Poppler-bugs] [Bug 102036] [PATCH] Arthur backend renders highlight annotations wrongly
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Sat Oct 28 19:31:59 UTC 2017
https://bugs.freedesktop.org/show_bug.cgi?id=102036
--- Comment #5 from oliver.sander at tu-dresden.de ---
I finally figured out how to make Arthur render highlight annotations properly.
(Thanks to Adrian for his advice---I should have listened earlier.) These
annotations need support for transparency groups. My implementation comes as
three separate patches:
1) The implementation of updateBlendMode. Please commit this, it is definitely
needed.
2) A patch that replaces the single QPainter object by a stack of QPainters.
That one is a bit invasive, that's why I'm submitting it separately. All
references to the current painter are now m_painter.top() rather than simple
m_painter. Having a getter method for that may be nice---I am undecided.
3) The actual implementations of {begin|end|paint}TransparenceGroup. These are
short and rudimentary. Transparency groups can do much more than just
highlights, but that has to wait until later.
Thanks for your review.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20171028/9ee080a1/attachment.html>
More information about the Poppler-bugs
mailing list