[Poppler-bugs] [Bug 105766] Add missing time.h to some headers

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105766

--- Comment #2 from Mojca Miklavec <mojca at macports.org> ---
Thank you.

The #ifdef MACOS is in fact used all over the place and I have absolutely no
clue what it does. It could be that some ancient version of xpdf would add that
definition somehow to help compilation on super old systems. See
https://sourceforge.net/p/predef/wiki/OperatingSystems/ for existing
definitions. Even if MACOS was defined on version Mac OS 8 or 9 (which probably
wasn't the case), this would not really help anyone.

Poppler can only be compiled on a relatively new macOS version (10.9 or newer
out of the box, potentially on older ones with a lot of additional effort, but
I bet nobody would dare to compile it on 10.3). I see there are some parts of
the code related to different newline character (CR instead of LF). See
https://superuser.com/a/439443

I bet that any code doing #ifdef MACOS can be removed without doing any harm
whatsoever. But sure, a separate commit makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180402/77b4d146/attachment-0001.html>