[Poppler-bugs] [Bug 105558] [PATCH] Expose more image modes, add option to select mode in renderer

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105558

--- Comment #7 from Albert Astals Cid <aacid at kde.org> ---
Sorry i took too much to come back.

Is there any reason you really need

-        format_invalid,
+        format_invalid = -1,

I think not, but want to double check with you.

?

That's bad since changes the value of format_invalid between versions. Also the
two new enums should be at the end so that the existing ones don't change
value.

Other than that looks good, no need to upload a new patch, just tell me if
format_invalid = -1 is needed or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180430/ed7699aa/attachment.html>