[Poppler-bugs] [Bug 107151] Add font color in Poppler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107151

--- Comment #18 from Dileep Sankhla <sankhla.dileep96 at gmail.com> ---
(In reply to Tobias Deiminger from comment #17)
> (In reply to Dileep Sankhla from comment #16)
> > Created attachment 140935 [details] [review] [review]
> > This patch includes Annot.cc to create and parse DA string
> 
> You mailed me yesterday, regarding review and fixing a segfault in your yet
> unpublished patch. Seems I was too slow, you fixed it yourself :) I have a
> local patch pending anyway now...
> 
> > Thanks @Tobias and @Albert for the review comments. I hope this patch is
> > what you expected at least for the font color with "invalid_font" Tf.
> > The font family patch will be patched from this current patch for including
> > font families in poppler.
> 
> I think it's good, there are some minor issues only, like adding a bit more
> const and performing a nullptr check on delete of
> DefaultAppearance::fontColor. It would be in my local patch, is it ok for
> you if we merge?
Yes I think now you should produce the final patch that's able to be merged
finally and please correct all the minor mistakes and submit the attachment
here. I would love to watch what I missed and in this end moment, I'm working
on my local fontfamily branch. Waiting for your patch :)

> 
> Finally, we should run available automated tests. Albert, I know how to
> execute poppler/qt5/tests/*. What about poppler/regtest/poppler-regtest, are
> there examples how to use it?
Now do I need to write the tests too?? What's this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180802/31616b55/attachment.html>