[Poppler-bugs] [Bug 105151] [PATCH] Fix various compiler warnings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Feb 20 07:38:13 UTC 2018


https://bugs.freedesktop.org/show_bug.cgi?id=105151

--- Comment #5 from Adam Reichold <adam.reichold at t-online.de> ---
(In reply to Albert Astals Cid from comment #3)
> -    QCOMPARE( page->search(QString("non-ascii:"), rectLeft, rectTop,
> rectRight, rectBottom, Poppler::Page::FromTop,
> Poppler::Page::CaseSensitive), true );
> +    QCOMPARE( page->search(QString("non-ascii:"), rectLeft, rectTop,
> rectRight, rectBottom, Poppler::Page::FromTop, Poppler::Page::IgnoreCase),
> true );
> 
> is wrong?

Indeed, thanks for spotting it. Fixed that in an updated version of the patch.
(It seems that the test is actually not dependent on that flag but still a
stronger check in the original version.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180220/1ac28fc9/attachment.html>


More information about the Poppler-bugs mailing list