[Poppler-bugs] [Bug 107057] [Patch] Skip XRef gaps in PDFDoc save methods

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107057

oliver.sander at tu-dresden.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver.sander at tu-dresden.de

--- Comment #5 from oliver.sander at tu-dresden.de ---
I trust your judgement on the efficiency impact.

>Ah, and by the way, it's not to make the loop "look pretty". It's to make the 
> loop non-contiguous (like 1, 4, 5, 6, 18, 19, 20,...), which is essentially the 
> reason why the patch fixes the bug.

I know that. :-)  But you could have written something like

for(int i=0; i<xref->getNumObjects(); i++) {
  if (entries[i].type == xrefEntryNone)
    continue;

which does the same, but is not as pretty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180629/10b06fc7/attachment.html>