[Poppler-bugs] [Bug 105558] [PATCH] Expose more image modes, add option to select mode in renderer

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105558

--- Comment #2 from Zsombor Hollay-Horvath <hbotondzs at gmail.com> ---
I removed the changes from CMakeLists.txt

The calc_bytes_per_row (poppler::image::rgb24) bug was the following: we are
using 4-padded lines. The current version simply multiplies the width by 3, so
that produces distorted images when the output image width isn't a multiply of
4. The version I propose manages to render the pdf correctly with any width.
I attached a test pdf and two renders, one with the original code, one with my
modifications.

On image::save I accidentally exchanged RGB24 with BGR24 in my previous patch,
I fixed that.
My BGR24 saving method also had a bug, that's also fixed.

According to our conversation with Cid, I removed the include of
splash/SplashTypes.h from the public header and added converter functions to
handle image_mode and line_modes both on public and on Splash side.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180321/b04929bf/attachment.html>