[Poppler-bugs] [Bug 106388] [patch] poppler-0.64.0 fails to compile when nss is present: ‘PRBool’ has not been declared

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106388

--- Comment #2 from William Bader <williambader at hotmail.com> ---
Thanks for looking at it. It looks like RedHat patches the source to remove the
include.

My Fedora 27 laptop has nss-util-devel-3.36.1-1.0.fc27.x86_64
/usr/include/nss3/hasht.h does not have any #includes.
I think I didn't have problems before because I only recently installed
nss-util-devel in order to build another application.

I checked older CentOS 7 and 6 systems. They do not have #includes in hasht.h
either. The packages are nss-util-devel-3.28.4-3.el7.x86_64 and
nss-util-devel-3.28.4-1.el6_9.x86_64

prtypes.h is in /usr/include/nspr4/prtypes.h in
nspr-devel-4.19.0-1.fc27.x86_64, nspr-devel-4.13.1-1.0.el7_3.x86_64, and
nspr-devel-4.13.1-1.el6.x86_64

The nss github source mirror has an include.
https://github.com/nss-dev/nss/blob/master/lib/util/hasht.h
The include was added five years ago
https://github.com/nss-dev/nss/blame/master/lib/util/hasht.h in
https://github.com/nss-dev/nss/commit/e4f3c454aca2c338191e921989e1617f182ba8fb

RedHat removes the include.
On Fedora 27, I downloaded the source rpm with dnf download --source
nss-util-devel
and unpacked it with rpm2cpio ../nss-util-3.36.1-1.0.fc27.src.rpm | cpio -idmv
--no-absolute-filenames
It has a patch file hasht-dont-include-prtypes.patch that removes the include.
The comments in nss-util.spec say
-----
# Local patches
Patch2: hasht-dont-include-prtypes.patch
Patch3: pkcs1sig-include-prtypes.patch
# TODO: investigate whether this patch should also be applied to
# nss-softokn and nss and whether it should be submitted upstream.
# First ensure that it won't cause any FIPS tests breakage.
Patch4: nss-util-3.19.3-ldflags.patch
# To revert the change in:
# https://bugzilla.mozilla.org/show_bug.cgi?id=1377940
Patch5: nss-util-sql-default.patch
-----
hasht-dont-include-prtypes.patch removes #include "prtypes.h" from
nss/lib/util/hasht.h
pkcs1sig-include-prtypes.patch adds #include "prtypes.h" to
nss/lib/util/pkcs1sig.c
nss-util-3.19.3-ldflags.patch changes nss-util-3.29.0/nss/coreconf/Linux.mk to
add -Wl,-z,now to DSO_LDOPTS
nss-util-sql-default.patch changes lib/util/utilpars.c to make dbType =
NSS_DB_TYPE_SQL the default even if NSS_DISABLE_DBM is not set.


Regards,
William

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180504/5e29fc29/attachment.html>