[Poppler-bugs] [Bug 106388] [patch] poppler-0.64.0 fails to compile when nss is present: ‘PRBool’ has not been declared

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=106388

--- Comment #4 from William Bader <williambader at hotmail.com> ---
I looked around on RedHat's bugzilla.
Removing the include for prtypes.h five years ago was an incorrect attempt at a
fix for a glibc build error.
About four years ago, someone filed a bug report about the incorrect removal of
the include. One of the nearly two dozen comments even notes that the bug
breaks poppler.
Supposedly the bug was fixed in September 2017, but the fix was not included in
Fedora 26 or 27.
So this is not a poppler bug. It is a RedHat bug and should hopefully be fixed
in Fedora 28 and RHEL 7.5 or 8.
I have some links below.
Regards,
William

https://bugzilla.redhat.com/show_bug.cgi?id=1113172
Bug 1113172 - hasht.h really should include prtypes.h
2014-06-25 10:33 EDT by Andrew Schultz

https://bugzilla.redhat.com/show_bug.cgi?id=1113172#c14
Tomas Mraz 2017-07-11 10:28:31 EDT
Yes, actually 2 downstream patches from the rpm should be dropped:
Patch2: hasht-dont-include-prtypes.patch
Patch3: pkcs1sig-include-prtypes.patch  
Both of these are an incorrect fix for the original issue (bug 953277 - rawhide
build of glibc fails due to fatal error from nss3/hasht.h)
The glibc build needs to learn to add -I/usr/include/nspr4 to CFLAGS instead.
This is little bit complicated by the thing that nss-config --includedir cannot
return two directories.
Thus glibc build must call also nspr-config --includedir. On the other hand
nss-config --cflags could be fixed to properly return -I/usr/include/nss3
-I/usr/include/nspr4 and if glibc used it instead of nss-config --includedir,
it would work as well.

https://bugzilla.redhat.com/show_bug.cgi?id=1113172#c15
David Tardon 2017-09-04 09:17:29 EDT
This breaks build of poppler 0.59.0 now. TBH, I find it hard to believe that
such thing could be left rotting for 2 years (and even closed as NOTABUG at one
point!)

https://bugzilla.redhat.com/show_bug.cgi?id=1113172#c19
Andrew Schultz 2017-11-16 14:18:41 EST
This was fixed in rawhide back in September (comment 16) with version 3.32.0-3,
but is not included with f26 or f27 builds.

https://bugzilla.redhat.com/show_bug.cgi?id=953277
Bug 953277 - rawhide build of glibc fails due to fatal error from nss3/hasht.h
2013-04-17 15:57 EDT by Patsy Franklin

https://bugzilla.redhat.com/show_bug.cgi?id=1489339
Bug 1489339 - glibc: don't rely on downstream modification of hasht.h
2017-09-07 05:01 EDT by Daiki Ueno

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180508/d3311d2f/attachment.html>