<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - pdftops sometimes creates huge PS 3 files out of small PDFs"
href="https://bugs.freedesktop.org/show_bug.cgi?id=81760#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - pdftops sometimes creates huge PS 3 files out of small PDFs"
href="https://bugs.freedesktop.org/show_bug.cgi?id=81760">bug 81760</a>
from <span class="vcard"><a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> <span class="fn">Adrian Johnson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=121582" name="attach_121582" title="patch to add LZW and Flate compression">attachment 121582</a> <a href="attachment.cgi?id=121582&action=edit" title="patch to add LZW and Flate compression">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=81760&attachment=121582'>[review]</a>
patch to add LZW and Flate compression
Review of <span class=""><a href="attachment.cgi?id=121582" name="attach_121582" title="patch to add LZW and Flate compression">attachment 121582</a> <a href="attachment.cgi?id=121582&action=edit" title="patch to add LZW and Flate compression">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=81760&attachment=121582'>[review]</a>:
-----------------------------------------------------------------
The LZW and Flate compression should be in two separate commits in order to
preserve the provenance of the code since the LZW code was copied from xpdf
while Flate is new code. The Glyph & Cog copyright dates in the source files,
poppler-config.h and man pages need updating.
::: .gitignore
@@ +36,4 @@
<span class="quote">> *.exe
> +*.pdf
> +*.ps
> +*.eps</span >
I don't think we want to add these to gitignore.
::: poppler/FlateEncoder.h
@@ +60,5 @@
<span class="quote">> + virtual GBool isEncoder() { return gTrue; }
> +
> +private:
> +
> + enum FlateEncoderEnum { inBufSize = 16384, outBufSize = inBufSize };</span >
Why use enums to define constants? The rest of the code uses #define or static
const.
::: poppler/Gfx.cc
@@ +2130,5 @@
<span class="quote">> + if (fabs(det) < 0.000001) {
> + error(errSyntaxError, getPos(), "Singular matrix in tiling pattern fill");
> + return;
> + }
> + det = 1 / det;</span >
What are the Gfx.cc changes for?
::: poppler/PSOutputDev.cc
@@ +3010,5 @@
<span class="quote">> + if (useFlate) {
> + str = new FlateEncoder(str);
> + } else
> +#endif
> + if (useLZW) {</span >
I would prefer to avoid using multiple "#if ENABLE_ZLIB" checks in this file.
In some places the flate code is wrapped in both the #if and "if (useFlate)".
In other places it just has the "if (useFlate)". It is not clear to anyone
modifying this file is there is a reason for the distinction.
It would be better to have just one
#ifndef ENABLE_ZLIB
useFlate = gFalse;
#endif
and rely on checking useFlate in the rest of the code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>