<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - pdftops sometimes creates huge PS 3 files out of small PDFs" href="https://bugs.freedesktop.org/show_bug.cgi?id=81760#c26">Comment # 26</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - pdftops sometimes creates huge PS 3 files out of small PDFs" href="https://bugs.freedesktop.org/show_bug.cgi?id=81760">bug 81760</a> from <a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> Adrian Johnson</a> <pre>(In reply to William Bader from <a href="show_bug.cgi?id=81760#c25">comment #25</a>) > OK. I did that so my test files wouldn't get picked up in my diffs. You could put them in your git global config. > enums for constants are better style, since they are scoped while #defines > are global. "static const" in the private section is scoped. I prefer that we stick to the existing poppler style which is #define or "static const". > >What are the Gfx.cc changes for? > > They are a fix from xpdf. Should I pull them out into a separate patch? Yes. It is unrelated to the compression patch. We will also need a comment to put in the commit message for the Gfx changes. I've got no idea what those changes are for. > I can remove the #if in the place that you mentioned. I thought that it was > better to wrap it to avoid generating extra code and data. I prefer to keep the #ifdef'd code to a minimum. The problem is, in addition to making the code harder to read, only the most commonly used build options (eg with zlib compress, without zlib uncompress) get regularly tested. Changes to the surrounding code may break the uncommon cases and not get picked up because none of the developers tested with uncommon build options.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>