<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - refactor GooString"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94201">94201</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>refactor GooString
</td>
</tr>
<tr>
<th>Product</th>
<td>poppler
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>general
</td>
</tr>
<tr>
<th>Assignee</th>
<td>poppler-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>jakubkucharski97@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=121823" name="attach_121823" title="patch">attachment 121823</a> <a href="attachment.cgi?id=121823&action=edit" title="patch">[details]</a></span>
patch
I've run The Clang Static Analyzer on poppler and among others there were some
issues with GooString. And so I discovered that GooString::Set() is used only
once to concatenate strings and it is in a GooString constructor used
specifically for that, so I think concatenation should take place in the
constructor and GooString::Set should do exactly what it says which is setting
the string.
In GooString::resize() there was a bug that under some circumstances would
effect in one of the arguments passed to memcpy being NULL. Another problem is
the use of memcpy. Given the possible prior use of realloc we can't be sure
that s doesn't point to an area somewhere in [s1, newLength), so it's
reasonable to call memmove instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>