<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:teuf@gnome.org" title="Christophe Fergeau <teuf@gnome.org>"> <span class="fn">Christophe Fergeau</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - remove or deprecate PopplerOrientation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93229">bug 93229</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>teuf@gnome.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - remove or deprecate PopplerOrientation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93229#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - remove or deprecate PopplerOrientation"
href="https://bugs.freedesktop.org/show_bug.cgi?id=93229">bug 93229</a>
from <span class="vcard"><a class="email" href="mailto:teuf@gnome.org" title="Christophe Fergeau <teuf@gnome.org>"> <span class="fn">Christophe Fergeau</span></a>
</span></b>
<pre>This unfortunately breaks both ABI and API for pypoppler. PopplerOrientation
was defined in poppler.h, which is passed to glib-mkenums in order to generate
the public header poppler-enums.h, and the diff for this header before/after
this commit is:
--- poppler-enums.h 2016-04-28 10:46:57.709931818 +0200
+++ glib/poppler-enums.h 2016-04-28 10:46:58.790928198 +0200
@@ -92,6 +92,8 @@
/* enumerations from "poppler.h" */
GType poppler_error_get_type (void) G_GNUC_CONST;
#define POPPLER_TYPE_ERROR (poppler_error_get_type ())
+GType poppler_orientation_get_type (void) G_GNUC_CONST;
+#define POPPLER_TYPE_ORIENTATION (poppler_orientation_get_type ())
GType poppler_page_transition_type_get_type (void) G_GNUC_CONST;
#define POPPLER_TYPE_PAGE_TRANSITION_TYPE
(poppler_page_transition_type_get_type ())
GType poppler_page_transition_alignment_get_type (void) G_GNUC_CONST;
ABI break is <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1323497">https://bugzilla.redhat.com/show_bug.cgi?id=1323497</a>
$pdfshuffler
Error: Could not import pdfshuffler
Cause: /usr/lib64/python2.7/site-packages/poppler.so: undefined symbol:
poppler_orientation_get_type
API break is <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1307888">https://bugzilla.redhat.com/show_bug.cgi?id=1307888</a>
poppler.c: In function 'py_poppler_add_constants':
poppler.c:4628:53: error: 'POPPLER_TYPE_ORIENTATION' undeclared (first use in
this function)
pyg_enum_add(module, "Orientation", strip_prefix, POPPLER_TYPE_ORIENTATION);
poppler.c:4628:53: note: each undeclared identifier is reported only once for
each function it appears in
Makefile:430: recipe for target 'poppler_la-poppler.lo' failed
I'll look at patching pypoppler, but these changes on poppler-glib side were
unexpected ;)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>