<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - refactor GooString"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94201#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - refactor GooString"
href="https://bugs.freedesktop.org/show_bug.cgi?id=94201">bug 94201</a>
from <span class="vcard"><a class="email" href="mailto:jakubkucharski97@gmail.com" title="Jakub Kucharski <jakubkucharski97@gmail.com>"> <span class="fn">Jakub Kucharski</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=94201#c5">comment #5</a>)
<span class="quote">> Can you explain why we need the
>
> "(s &&" part?
>
> I don't see why it would be needed.</span >
Without it Clang Static Analyzer says "Null pointer passed as an argument to a
'nonnull' parameter" on lines 166 and 168. That ("(s &&") part is to prevent
passing a null pointer to memmove (or memcpy in the previous version of the
code) as a second argument.
(Sorry for the time it took me to reply. I've been preparing for my exams.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>