<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - return dates in UTC format" href="https://bugs.freedesktop.org/show_bug.cgi?id=94173#c24">Comment # 24</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - return dates in UTC format" href="https://bugs.freedesktop.org/show_bug.cgi?id=94173">bug 94173</a> from <a class="email" href="mailto:jakubkucharski97@gmail.com" title="Jakub Kucharski <jakubkucharski97@gmail.com>"> Jakub Kucharski</a> <pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=94173#c22">comment #22</a>) > Ok, so I guess you have convinced me, let's give Jakub some time to comment > about what he thinks of the patches. Sorry, I've been quiet occupied recently. I'd prefer if the code of poppler_date_parse() was somehow moved to core and used by glib and cpp, because now it does the same thing as detail::convert_date from cpp. This way we could avoid doubling the effort put into fixing/changing the way time conversion works. I think these two functions should stay (especially since one (overloaded) version of convert_date is exported as public API), but they should call a function from core which would do all the work. But this is of course open for discussion. Other than that, everything seems ok to me.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>