<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Crash when calling cmsGetColorSpace" href="https://bugs.freedesktop.org/show_bug.cgi?id=97870#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Crash when calling cmsGetColorSpace" href="https://bugs.freedesktop.org/show_bug.cgi?id=97870">bug 97870</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>(In reply to Marek Kasik from <a href="show_bug.cgi?id=97870#c1">comment #1</a>) > Created <a href="attachment.cgi?id=126645" name="attach_126645" title="Don't crash when calling cmsGetColorSpace()">attachment 126645</a> <a href="attachment.cgi?id=126645&action=edit" title="Don't crash when calling cmsGetColorSpace()">[details]</a> <a href='page.cgi?id=splinter.html&bug=97870&attachment=126645'>[review]</a> [review] > Don't crash when calling cmsGetColorSpace() > > This patch fixes the problem for me. Is that the only place where all those global variables could be used uninitialized? GfxColorSpace::setupColorProfiles() is already protected to ensure it only happens once even if called multiple times, so I think it would be simpler to call it unconditionally before trying to use RGBProfile. But I would make this generic, the current use of all those global vars is very weak in my opinion. I would make a global singleton to contain those variables or something similar.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>