<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mkasik@redhat.com" title="Marek Kasik <mkasik@redhat.com>"> <span class="fn">Marek Kasik</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when calling cmsGetColorSpace"
href="https://bugs.freedesktop.org/show_bug.cgi?id=97870">bug 97870</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #126645 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when calling cmsGetColorSpace"
href="https://bugs.freedesktop.org/show_bug.cgi?id=97870#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when calling cmsGetColorSpace"
href="https://bugs.freedesktop.org/show_bug.cgi?id=97870">bug 97870</a>
from <span class="vcard"><a class="email" href="mailto:mkasik@redhat.com" title="Marek Kasik <mkasik@redhat.com>"> <span class="fn">Marek Kasik</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=126698" name="attach_126698" title="Don't crash when calling cmsGetColorSpace()">attachment 126698</a> <a href="attachment.cgi?id=126698&action=edit" title="Don't crash when calling cmsGetColorSpace()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=97870&attachment=126698'>[review]</a>
Don't crash when calling cmsGetColorSpace()
(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=97870#c2">comment #2</a>)
<span class="quote">> (In reply to Marek Kasik from <a href="show_bug.cgi?id=97870#c1">comment #1</a>)
> > Created <span class="bz_obsolete"><a href="attachment.cgi?id=126645" name="attach_126645" title="Don't crash when calling cmsGetColorSpace()">attachment 126645</a> <a href="attachment.cgi?id=126645&action=edit" title="Don't crash when calling cmsGetColorSpace()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=97870&attachment=126645'>[review]</a> [review] [review]
> > Don't crash when calling cmsGetColorSpace()
> >
> > This patch fixes the problem for me.
>
> Is that the only place where all those global variables could be used
> uninitialized? GfxColorSpace::setupColorProfiles() is already protected to
> ensure it only happens once even if called multiple times, so I think it
> would be simpler to call it unconditionally before trying to use RGBProfile.</span >
Some of those variables can be used uninitialized via getters like:
GfxColorSpace::getRGBProfile()
GfxColorSpace::getDisplayProfile()
The XYZ2DisplayTransform is also used in some ::parse() methods but these
usages are guarded by consequent NULL checks.
I've changed the patch to call the setup of color profiles unconditionally.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>